make sure build and UT run for all modules

Author: Aggarwal-Raghav

dev-support/tez-personality.sh

@@ -41,9 +41,14 @@ function personality_globals
 
   # Default Yetus settings for Tez
   # shellcheck disable=SC2034
-  DOCKERMEMLIMIT=20g
+  DOCKER_MEMORY="20g"
   # shellcheck disable=SC2034
-  PROCLIMIT=5500
+  PROC_LIMIT=5500
+
+  # Unconditionally add compile and unit tests to ensure full build/UT on every PR as requested.
+  # add_test in personality_globals is the recommended way in 0.15.1 to force-enable plugins.
+  add_test compile
+  add_test unit
 }
 
 ## @description  Module selection
@@ -59,11 +64,14 @@ function personality_modules
 
   yetus_debug "Personality: ${repostatus} ${testtype}"
 
+  # Ensure a clean state for every test type
   clear_personality_queue
 
   extra="-Ptest-patch"
 
-  # Always run these tests on the root module to ensure everything is covered
+  # Always run these tests on the root module to ensure everything is covered.
+  # Note: Analysis tests (javac, spotbugs, checkstyle, javadoc) are NOT forced to root
+  # to allow them to run "smartly" only on changed modules.
   if [[ ${testtype} == unit || ${testtype} == compile || ${testtype} == mvninstall ]]; then
     yetus_debug "Forcing root module and fail-at-end for ${testtype}"
     extra="${extra} -fae"
@@ -84,20 +92,21 @@ function personality_modules
 ## @audience     private
 ## @stability    evolving
 ## @replaceable  no
-function tez_file_filter
+function personality_file_filter
 {
   local filename=$1
 
   yetus_debug "Tez file filter: ${filename}"
 
-  # Unconditionally add compile and unit tests to ensure full build/UT on every PR as requested
-  add_test compile
-  add_test unit
-
-  if [[ ${filename} =~ \.java$ ]]; then
+  if [[ ${filename} =~ \.java$ || ${filename} =~ \.proto$ || ${filename} =~ pom\.xml$ ]]; then
     add_test javac
     add_test spotbugs
     add_test checkstyle
+    add_test javadoc
+  fi
+
+  if [[ ${filename} =~ findbugs-exclude\.xml$ ]]; then
+    add_test spotbugs
   fi
 
   if [[ ${filename} =~ \.sh$ ]] || [[ ${filename} =~ Jenkinsfile ]]; then