fix: biome issues

Author: anthonny

biome.json

@@ -4,15 +4,32 @@
   "linter": {
     "enabled": true,
     "rules": {
-      "recommended": true
+      "recommended": true,
+      "suspicious": {
+        "noTemplateCurlyInString": "off"
+      }
     },
-    "includes": ["**", "!**/dist/**", "!**/node_modules/**", "!**/.turbo/**"]
+    "includes": [
+      "**",
+      "!**/dist/**",
+      "!**/node_modules/**",
+      "!**/.turbo/**",
+      "!**/generated/**",
+      "!**/coverage/**"
+    ]
   },
   "formatter": {
     "enabled": true,
     "indentStyle": "space",
     "indentWidth": 2,
-    "includes": ["**", "!**/dist/**", "!**/node_modules/**"]
+    "includes": [
+      "**",
+      "!**/dist/**",
+      "!**/node_modules/**",
+      "!**/.turbo/**",
+      "!**/generated/**",
+      "!**/coverage/**"
+    ]
   },
   "javascript": {
     "formatter": {

packages/lib/src/__tests__/multi-tab-support.test.ts

@@ -1,6 +1,5 @@
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import { Workerify } from '../index.js';
-import type { BroadcastMessage } from '../types.js';
 
 // Mock fetch for registration
 global.fetch = vi.fn();
@@ -41,9 +40,11 @@ class MockBroadcastChannel {
   }
 
   // Helper to simulate receiving a message
-  simulateMessage(data: any) {
+  simulateMessage(data: unknown) {
     const event = new MessageEvent('message', { data });
-    this.listeners.get('message')?.forEach((listener) => listener(event));
+    this.listeners.get('message')?.forEach((listener) => {
+      listener(event);
+    });
   }
 }
 
@@ -58,7 +59,9 @@ describe('Multi-tab Support', () => {
     vi.clearAllMocks();
     mockFetch = global.fetch as ReturnType<typeof vi.fn>;
     // Mock location for proper URL
-    global.location = { origin: 'http://localhost:3000' } as any;
+    global.location = {
+      origin: 'http://localhost:3000',
+    } as unknown as Location;
     workerify = new Workerify({ logger: false });
   });
 
@@ -71,9 +74,9 @@ describe('Multi-tab Support', () => {
       const instance1 = new Workerify({ logger: false });
       const instance2 = new Workerify({ logger: false });
 
-      // Access private property through any cast
-      const consumerId1 = (instance1 as any).consumerId;
-      const consumerId2 = (instance2 as any).consumerId;
+      // Access private property through type assertion
+      const consumerId1 = (instance1 as { consumerId: string }).consumerId;
+      const consumerId2 = (instance2 as { consumerId: string }).consumerId;
 
       expect(consumerId1).toBeDefined();
       expect(consumerId2).toBeDefined();

packages/lib/src/__tests__/plugins.test.ts

@@ -241,7 +241,7 @@ describe('Plugin System', () => {
           options;
 
         // Add OPTIONS handler for preflight
-        app.option('/*', (req, reply) => {
+        app.option('/*', (_req, reply) => {
           reply.headers = {
             'Access-Control-Allow-Origin': origin.join(', '),
             'Access-Control-Allow-Methods': methods.join(', '),
@@ -270,7 +270,7 @@ describe('Plugin System', () => {
       const loggingPlugin: WorkerifyPlugin = (app) => {
         // In a real implementation, this would intercept requests
         // For testing, we'll just add a route that logs
-        app.all('/logged/*', (req, reply) => {
+        app.all('/logged/*', (req, _reply) => {
           logs.push(`${req.method} ${req.url}`);
           return { logged: true };
         });
@@ -295,7 +295,7 @@ describe('Plugin System', () => {
         const { secret, protected: protectedRoutes } = options;
 
         // Add auth route
-        app.post('/auth/login', (req) => {
+        app.post('/auth/login', (_req) => {
           // Simulate authentication
           return { token: 'fake-jwt-token', secret };
         });

packages/lib/src/__tests__/request-handling.test.ts

@@ -1,12 +1,10 @@
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import { Workerify } from '../index.js';
-import type { WorkerifyReply, WorkerifyRequest } from '../types.js';
+import type { WorkerifyReply } from '../types.js';
 import {
-  createMockReply,
   createMockRequest,
   setupBroadcastChannelMock,
   stringToArrayBuffer,
-  waitForAsync,
 } from './test-utils.js';
 
 // Setup mocks
@@ -273,7 +271,7 @@ describe('Request Handling', () => {
     });
 
     it('should allow handlers to modify reply object', async () => {
-      const handler = vi.fn().mockImplementation((req, reply) => {
+      const handler = vi.fn().mockImplementation((_req, reply) => {
         reply.status = 201;
         reply.statusText = 'Created';
         reply.headers = { 'X-Custom': 'value' };
@@ -445,7 +443,7 @@ describe('Request Handling', () => {
 
   describe('BroadcastChannel response sending', () => {
     it('should send response via BroadcastChannel', () => {
-      const postMessage = vi.spyOn(workerify['channel'], 'postMessage');
+      const postMessage = vi.spyOn(workerify.channel, 'postMessage');
       const sendResponse = (workerify as any).sendResponse.bind(workerify);
 
       const reply: WorkerifyReply = {

packages/lib/src/__tests__/test-utils.ts

@@ -2,14 +2,14 @@ import type { WorkerifyReply, WorkerifyRequest } from '../types.js';
 
 // Mock BroadcastChannel for testing
 export class MockBroadcastChannel {
-  private listeners: Array<(event: { data: any }) => void> = [];
+  private listeners: Array<(event: { data: unknown }) => void> = [];
   name: string;
 
   constructor(name: string) {
     this.name = name;
   }
 
-  postMessage(data: any) {
+  postMessage(data: unknown) {
     // Simulate async message delivery
     setTimeout(() => {
       this.listeners.forEach((listener) => {
@@ -18,13 +18,16 @@ export class MockBroadcastChannel {
     }, 0);
   }
 
-  addEventListener(type: string, listener: (event: { data: any }) => void) {
+  addEventListener(type: string, listener: (event: { data: unknown }) => void) {
     if (type === 'message') {
       this.listeners.push(listener);
     }
   }
 
-  removeEventListener(type: string, listener: (event: { data: any }) => void) {
+  removeEventListener(
+    type: string,
+    listener: (event: { data: unknown }) => void,
+  ) {
     if (type === 'message') {
       const index = this.listeners.indexOf(listener);
       if (index > -1) {
@@ -37,7 +40,7 @@ export class MockBroadcastChannel {
     this.listeners = [];
   }
 
-  set onmessage(handler: ((event: { data: any }) => void) | null) {
+  set onmessage(handler: ((event: { data: unknown }) => void) | null) {
     if (handler) {
       this.addEventListener('message', handler);
     }
@@ -53,7 +56,14 @@ export function createMockRequest(
 ): WorkerifyRequest {
   return {
     url,
-    method: method as any,
+    method: method as
+      | 'GET'
+      | 'POST'
+      | 'PUT'
+      | 'DELETE'
+      | 'PATCH'
+      | 'HEAD'
+      | 'OPTIONS',
     headers: {
       'user-agent': 'test',
       ...headers,

packages/lib/src/__tests__/types.test.ts

@@ -123,23 +123,23 @@ describe('Type Definitions', () => {
 
   describe('RouteHandler', () => {
     it('should support synchronous handlers', () => {
-      const handler: RouteHandler = (request, reply) => {
+      const handler: RouteHandler = (_request, _reply) => {
         return 'sync response';
       };
 
       expect(typeof handler).toBe('function');
     });
 
     it('should support asynchronous handlers', () => {
-      const handler: RouteHandler = async (request, reply) => {
+      const handler: RouteHandler = async (_request, _reply) => {
         return Promise.resolve('async response');
       };
 
       expect(typeof handler).toBe('function');
     });
 
     it('should support handlers that return void', () => {
-      const handler: RouteHandler = (request, reply) => {
+      const handler: RouteHandler = (_request, reply) => {
         reply.status = 200;
         reply.body = 'modified reply';
         // No return value
@@ -305,15 +305,15 @@ describe('Type Definitions', () => {
 
   describe('WorkerifyPlugin', () => {
     it('should support synchronous plugin', () => {
-      const plugin: WorkerifyPlugin = (instance, options) => {
+      const plugin: WorkerifyPlugin = (_instance, _options) => {
         // Plugin implementation
       };
 
       expect(typeof plugin).toBe('function');
     });
 
     it('should support asynchronous plugin', () => {
-      const plugin: WorkerifyPlugin = async (instance, options) => {
+      const plugin: WorkerifyPlugin = async (_instance, _options) => {
         return Promise.resolve();
       };
 
@@ -326,7 +326,7 @@ describe('Type Definitions', () => {
         enabled: boolean;
       }
 
-      const plugin: WorkerifyPlugin = (instance, options: PluginOptions) => {
+      const plugin: WorkerifyPlugin = (_instance, options: PluginOptions) => {
         if (options?.enabled) {
           // Plugin logic
         }
@@ -336,7 +336,7 @@ describe('Type Definitions', () => {
     });
 
     it('should support plugin without options', () => {
-      const plugin: WorkerifyPlugin = (instance) => {
+      const plugin: WorkerifyPlugin = (_instance) => {
         // Plugin implementation without options
       };
 
@@ -348,7 +348,7 @@ describe('Type Definitions', () => {
     it('should allow route handlers to be assigned to RouteHandler type', () => {
       const syncHandler = () => 'sync';
       const asyncHandler = async () => 'async';
-      const voidHandler = (req: WorkerifyRequest, reply: WorkerifyReply) => {
+      const voidHandler = (_req: WorkerifyRequest, reply: WorkerifyReply) => {
         reply.status = 200;
       };
 

packages/lib/src/__tests__/workerify.test.ts

@@ -1,10 +1,6 @@
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import { Workerify } from '../index.js';
-import {
-  createMockRequest,
-  setupBroadcastChannelMock,
-  waitForAsync,
-} from './test-utils.js';
+import { setupBroadcastChannelMock } from './test-utils.js';
 
 // Setup mocks
 setupBroadcastChannelMock();
@@ -134,8 +130,8 @@ describe('Workerify', () => {
 
       // Mock routes acknowledgment
       setTimeout(() => {
-        const channel = workerify['channel'] as any;
-        if (channel && channel.listeners) {
+        const channel = workerify.channel as any;
+        if (channel?.listeners) {
           channel.listeners.forEach((listener: any) => {
             listener({
               data: {
@@ -171,8 +167,8 @@ describe('Workerify', () => {
       });
 
       setTimeout(() => {
-        const channel = workerify['channel'] as any;
-        if (channel && channel.listeners) {
+        const channel = workerify.channel as any;
+        if (channel?.listeners) {
           channel.listeners.forEach((listener: any) => {
             listener({
               data: {
@@ -198,8 +194,8 @@ describe('Workerify', () => {
       });
 
       setTimeout(() => {
-        const channel = workerify['channel'] as any;
-        if (channel && channel.listeners) {
+        const channel = workerify.channel as any;
+        if (channel?.listeners) {
           channel.listeners.forEach((listener: any) => {
             listener({
               data: {
@@ -226,8 +222,8 @@ describe('Workerify', () => {
       });
 
       setTimeout(() => {
-        const channel = workerify['channel'] as any;
-        if (channel && channel.listeners) {
+        const channel = workerify.channel as any;
+        if (channel?.listeners) {
           channel.listeners.forEach((listener: any) => {
             listener({
               data: {
@@ -263,7 +259,7 @@ describe('Workerify', () => {
 
   describe('Integration with BroadcastChannel', () => {
     it('should NOT send route updates when routes are registered (deferred to listen)', async () => {
-      const channelSpy = vi.spyOn(workerify['channel'], 'postMessage');
+      const channelSpy = vi.spyOn(workerify.channel, 'postMessage');
 
       workerify.get('/test', () => 'test');
 
@@ -272,7 +268,7 @@ describe('Workerify', () => {
     });
 
     it('should update service worker routes on listen', async () => {
-      const channelSpy = vi.spyOn(workerify['channel'], 'postMessage');
+      const channelSpy = vi.spyOn(workerify.channel, 'postMessage');
 
       workerify.get('/test1', () => 'test1');
       workerify.post('/test2', () => 'test2');
@@ -286,8 +282,8 @@ describe('Workerify', () => {
       });
 
       setTimeout(() => {
-        const channel = workerify['channel'] as any;
-        if (channel && channel.listeners) {
+        const channel = workerify.channel as any;
+        if (channel?.listeners) {
           channel.listeners.forEach((listener: any) => {
             listener({
               data: {

packages/lib/src/index.ts

@@ -354,7 +354,7 @@ export class Workerify {
           if (this.options.logger) {
             console.log('[Workerify] Routes registered successfully');
           }
-          resolve(message.body || false);
+          resolve(typeof message.body === 'boolean' ? message.body : false);
         }
       };
       this.channel.postMessage({